feat(Navigation/Document): allow YQL query button if /@_yql_type == "view" [YTFRONT-4463]
#849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimbiozizV
reviewed
Nov 11, 2024
packages/ui/src/ui/containers/OpenQueryButton/OpenQueryButton.tsx
Outdated
Show resolved
Hide resolved
ma-efremoff
force-pushed
the
ma-efremoff/yql-view
branch
4 times, most recently
from
483c88e to
bce6589
Compare
ma-efremoff
force-pushed
the
ma-efremoff/yql-view
branch
5 times, most recently
from
a1627f0 to
8b06161
Compare
ma-efremoff
force-pushed
the
ma-efremoff/yql-view
branch
3 times, most recently
from
c132a20 to
d18d688
Compare
SimbiozizV
reviewed
Nov 29, 2024
| openWidget(); | ||
| }, [dispatch, path, cluster, openWidget]); | ||
|
|
||
| return !isQtKitEnabled ? null : ( |
There was a problem hiding this comment.
This isn't a bug, but I wouldn't put the c condition here !
Readability is slightly better without it
SimbiozizV
previously approved these changes
Nov 29, 2024
…view" [YTFRONT-4463]
ma-efremoff
force-pushed
the
ma-efremoff/yql-view
branch
from
bc40760 to
15c52c6
Compare
ma-efremoff
force-pushed
the
ma-efremoff/yql-view
branch
2 times, most recently
from
21cc9d9 to
72c29a9
Compare
ma-efremoff
force-pushed
the
ma-efremoff/yql-view
branch
from
72c29a9 to
ed42d4b
Compare
SimbiozizV
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nda.ya.ru/t/1KoGXc_n79VQMv